Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced use of pip internal function. #127

Closed
wants to merge 1 commit into from

Conversation

tannart
Copy link

@tannart tannart commented May 2, 2018

As discussed in this thread: pypa/pip#5243
use of the functions inside pip._internal is strongly discouraged. As
such I have replaced this functions usage with the pip maintainers
recommended solution.

As discussed in this thread: pypa/pip#5243
use of the functions inside pip._internal is strongly discouraged. As
such I have replaced this functions usage with the pip maintainers
recommended solution.
@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #127 into master will decrease coverage by 0.44%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   68.09%   67.64%   -0.45%     
==========================================
  Files           7        7              
  Lines         304      306       +2     
==========================================
  Hits          207      207              
- Misses         97       99       +2
Impacted Files Coverage Δ
safety/cli.py 47.05% <0%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9c780...62e07ee. Read the comment docs.

@Jwomers
Copy link
Member

Jwomers commented Jan 8, 2019

Thanks, closing this, going forward with #151 which solves the same problem.

@Jwomers Jwomers closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants