Change Dataset Gallery cell type color to provide higher contrast #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6475 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 142 142
Lines 27004 27004
=======================================
Hits 26270 26270
Misses 734 734 |
This reverts commit cbdf967.
tkoyama010
requested changes
Aug 8, 2024
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
|
Looks like not all the pydata colors are supported :(. It's probably strictly limited to just these: https://sphinx-design.readthedocs.io/en/latest/badges_buttons.html |
|
Using the |
tkoyama010
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The color for the cell types is currently set to
dark, but this color is static and does not change when the dark theme is used. This makes it hard to see.:This PR changes it to the use the
surfacecolor fromhttps://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/styling.html#color-variables