Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyxem/scikit-learn deps, adapt pyxem virtual imaging #168

Merged
merged 3 commits into from
May 13, 2020

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented May 12, 2020

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description

Remove dependency on pyxem and explicit dependency on scikit-learn (implicit via HyperSpy).

Adapted interactive virtual imaging and getting virtual image from pyxem. This was done to remove the pyxem dependency. Since this was the only dependent code, I consider it unnecessary to depend on pyxem (with diffsims stuff etc.) for now. Might reintroduce the dependency later.

Checklist

Minimal example of the bug fix or new feature

Nothing has changed, other than it being much faster thanks to the pyxem/HyperSpy teams:

>>> import kikuchipy as kp
>>> import hyperspy.api as hs
>>> s = kp.load("some_data.h5")
>>> roi = hs.roi.RectangularROI(0, 0, 10, 10)
>>> s.virtual_backscatter_electron_imaging(roi1)  # Interactive
>>> vbse = s.get_virtual_image(roi)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added enhancement New feature or request documentation This relates to the documentation labels May 12, 2020
@hakonanes hakonanes added this to the v0.2.0 milestone May 12, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 2ead000 on hakonanes:update-virtual-imaging into a128bea on kikuchipy:master.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit 5032787 into pyxem:master May 13, 2020
@hakonanes hakonanes deleted the update-virtual-imaging branch May 13, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This relates to the documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants