-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zone axes to geometrical EBSD simulations, improve plotting of simulation features #232
Merged
hakonanes
merged 14 commits into
pyxem:master
from
hakonanes:complete-zoneaxis-test-documentation
Oct 21, 2020
Merged
Add zone axes to geometrical EBSD simulations, improve plotting of simulation features #232
hakonanes
merged 14 commits into
pyxem:master
from
hakonanes:complete-zoneaxis-test-documentation
Oct 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…lete-zoneaxis-test-documentation
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…or uvw from hkl Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…ing) Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
… sim. Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes
changed the title
Add zone axes to geometrical EBSD simulations, improve other simulation features
Add zone axes to geometrical EBSD simulations, improve plotting of simulation features
Oct 21, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR concludes the basic functionality of simulations of geometrical EBSD patterns.
GeometricalEBSDSimulation
class. These are calculated from the cross product of the present Kikuchi bands, and can be plotted along with the bands.diffsims.crystallography.ReciprocalLatticePoint.unique()
method.KikuchiBand
andZoneAxis
__getitem__()
methods are added. These should also, I think, be moved toReciprocalLatticePoint.__getitem__()
.Progress of the PR
Jupyter Notebook showing how to simulate geometrical EBSD patterns and plot them as markers. This notebook should be placed inwill do this in a later PR.doc/notebook.ipynb
and included in the user guide withnbsphinx
(https://nbsphinx.readthedocs.io/en/0.7.1/index.html)For reviewers
later.
__init__.py
.the unreleased section in
doc/changelog.rst
.