-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Pattern Simulation #239
Conversation
Keeping up to date.
Update from upstream/master
Rest of the suggested changes will be done as soon as #246 closes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
My plane leaves now, so I will finish this review later this evening or tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, great stuff.
I think after these changes, we're good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick and good changes, only one change remains (I wasn't clear in my comment in the previous review, sorry).
Will merge after that change is made and checks pass.
Thanks a lot for this work, @friedkitteh 🎉 🎉 And for acting on my suggested changes so quickly, making the review process quick and easy 😄 |
Description of the change
Method for sampling patterns from an EBSDDetector()
Closes #229
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
later.
__init__.py
.the unreleased section in
doc/changelog.rst
.