-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EBSDMasterPattern.get_patterns() allow a 2D navigation shape + minor improvements #275
Make EBSDMasterPattern.get_patterns() allow a 2D navigation shape + minor improvements #275
Conversation
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@friedkitteh I would appreciate it if you could take a look at the changes made to the |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logical improvements in ebsd_master_pattern.py
(and the following tests)!
In the docstrings we now refer to the "Lambert projection" in 3 different ways:
- Lambert projection
- (modified) Lambert projection
- Rosca-Lambert projection
it would probably be beneficial to refer to them with the same name?
Since we map 3D vectors on parts of the northern or southern hemisphere of the Kikuchi sphere (our detector) onto a 2D square grid, and Callahan and De Graef call this the modified Lambert projection, I think we should as well. I'll therefore go with "Modified Lambert projection". What do you think of this, @friedkitteh? |
Yep - That sounds reasonable. |
Or, you know what, we could provide some more information in the naming by calling it the "square Lambert projection" instead. |
I'm glad you asked that question... I actually think we should rename the |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is much clearer now!
It probably wouldn't hurt.. |
Description of the change
Several changes to the
EBSDMasterPattern
class:EBSDMasterPattern.get_patterns()
. The progressbar is dask's ownProgressBar()
.EBSDMasterPattern.get_patterns()
accept aRotation
with a 2D navigation shape, i.e. of shape (ny, nx, 4), and return anEBSD
signal with a (ny, nx) navigation shape.Other changes:
get_patterns()
only working for cubic crystals.Closes #270 and #265.
Progress of the PR
get_patterns()
Minimal example of the bug fix or new feature
Will add more examples as stuff is done.
For reviewers
later.
__init__.py
.the unreleased section in
doc/changelog.rst
.