Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diffsims dependency and getting hkl data from ReciprocalLatticePoint #282

Merged

Conversation

hakonanes
Copy link
Member

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

  • Set hard diffsims >= 0.4 dependency
  • Update use of hkl data from diffsims.crystallography.ReciprocalLatticePoint from ._hkldata to hkl.data

Progress of the PR

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added bug Something isn't working maintenance This relates to package maintenance labels Jan 12, 2021
@hakonanes hakonanes added this to the v0.3.0 milestone Jan 12, 2021
@hakonanes hakonanes self-assigned this Jan 12, 2021
@hakonanes
Copy link
Member Author

Will merge when checks pass.

@hakonanes hakonanes merged commit 37518b6 into pyxem:master Jan 12, 2021
@hakonanes hakonanes deleted the fix-reciprocallatticepoint-hkl-use branch January 12, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant