Overwrite deepcopy for EBSD and EBSDMasterPattern to carry over custom properties #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Signal2D.deepcopy()
is overwritten for theEBSD
andEBSDMasterPattern
signals to carry over the following custom properties:xmap
anddetector
phase
(orix.crystal_map.Phase),projection
(str), andhemisphere
EBSD.xmap
property settable. A private function located inkikuchipy.signals.util._crystal_map.py
is added to ensure that the crystal map and EBSD signal has the same navigation shape and navigation step sizes (e.g. 1 um). This function should be used whenever theEBSD.xmap
property is used, ensuring that a reasonable error message is raised if the map and signal aren't compatible.Close #345.
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.unreleased section in
doc/changelog.rst
.