-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix projection center conversions in EBSDDetector #455
Conversation
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Follow up bug fix for pattern centre conversions
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Pinned h5py to <= 3.4 so it works with HyperSpy <= 1.6.4. This pinning should be removed when HyperSpy 1.6.5 is released, and HyperSpy's lowest supported version should be pinned to >= 1.6.5. I've added a TODO to remember this. @IMBalENce: I've added you to package credits and the All Contributors table. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
I've set the planned release date of the v0.5.3 patch release to coming Monday November 1st. |
I'll merge after checks pass. |
Description of the change
Addresses multiple issues with conversions of projection center (PC) coordinates between conventions identified in #449, thanks to @IMBalENce. I believe the conversion will be more correct after these changes:
EMsoft's xpc coordinate was wrongly flipped given v4 and v5, should be correct now. Basically, with EMsoft v5, a positive xpc now gives x* > 0.5.@IMBalENce, if you find the time, I would appreciate it if you could review the definitions below. If you do so, is it OK if I add you to the contributor list in the changelog to the next patch release, and also to the all-contributors table in the README?
We should release v0.5.3 from
main
after this PR is in.Fix #449.
The
EBSDDetector.__init__()
docstring has these additions:The
EBSDDetector.pc_emsoft()
docstring has these additions:The
EBSDDetector.pc_tsl()
docstring has these additions (equivalent equations forpc_oxford()
):Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.section in
CHANGELOG.rst
.