-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EMsoft ECP/TKD master pattern readers, improve handling of custom properties #564
Merged
hakonanes
merged 21 commits into
pyxem:develop
from
hakonanes:ecp-tkd-master-pattern-reader
Sep 22, 2022
Merged
Add EMsoft ECP/TKD master pattern readers, improve handling of custom properties #564
hakonanes
merged 21 commits into
pyxem:develop
from
hakonanes:ecp-tkd-master-pattern-reader
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…tom properties Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…dling Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
This was
linked to
issues
Sep 21, 2022
Closed
Closed
13 tasks
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…done Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds readers for EMsoft's ECP and TKD master patterns. The former returns a new
ECPMasterPattern
signal, which is similar toEBSDMasterPattern
withoutget_patterns()
, while the latter returns aEBSDMasterPattern
.In the process of generalizing the master pattern class, I reimplemented the private
CommonImage
class inKikuchipySignal2D
andLazyKikuchipySignal2D
. The new class handles custom properties (not in HyperSpy), likeEBSD.static_background()
andEBSDMasterPattern.phase
, and wraps calls to methodsas_lazy()
,change_dtype()
,compute()
,squeeze()
anddeepcopy()
so that these properties carry over to or are removed in new signals as appropriate. All custom properties are also carried over when switching betweenECPMasterPattern
andEBSDMasterPattern
usingset_signal_type()
.Finally, logging is added via
kikuchipy.set_log_level()
(same as in HyperSpy), since I needed this to debug the wrapped Signal2D methods mentioned above.Replaces #476.
Closes #512, #386 and #16.
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
and.all-contributorsrc
and the tableis regenerated.