Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EDAX binary reader and prepare for 0.8.6 patch release #641

Merged
merged 13 commits into from
May 29, 2023

Conversation

hakonanes
Copy link
Member

Description of the change

Fixes:

  • A bug where patterns from an EDAX binary .up1 file appears shifted horizontally. This was because of an incorrect offset for
    the pattern starts.
  • Allow reading of EBSD patterns from H5OINA files without explicit information about the camera binning factor.

Other changes:

  • Use numpy.memmap() instead of numpy.fromfile() for non-lazy reading of patterns from EDAX binary up1/up2 files. This should reduce memory use when the pattern array is only read and not written to.
  • List OpenECCI and PyEBSDIndex among related projects.
  • Add two recent publications using kikuchipy to the list of applications.

Prepare to release these fixes and change as a 0.8.6 patch.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added bug Something isn't working documentation This relates to the documentation maintenance This relates to package maintenance labels May 28, 2023
@hakonanes hakonanes added this to the v0.8.6 milestone May 28, 2023
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Copy link
Member Author

I plan to merge and release the 0.8.6 patch tomorrow Monday 29th.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit f3d93d1 into pyxem:main May 29, 2023
@hakonanes hakonanes deleted the fix-edax-binary-reader branch May 29, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation This relates to the documentation maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant