-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package should support Ember 3.4.7 #8
Comments
Yep, definitely agree. |
I wanted to take care of fixing this myself, but I'm not sure where the If someone can let me know where that comes from (and presumably, how they are doctored) I'm happy to make the PR to close this issue. |
Note: I think the lack of support here also explains why the tests are failing, since the |
The polyfill branches are
It should be possible to rebase the current branch ontop of the latest patch release and rebuild. For the non legacy part of the polyfill, you have to remove all of the ES5 transforms. I can do this later today, but happy to merge if you have time to make a PR. |
I probably won't have time, to be honest. I have a bunch of work stuff on my plate for today. |
This won't work _yet_, because of pzuraq/ember-native-class-polyfill#8
Support for 3.4.7 added in v1.0.5! |
It seems like
ember-source@3.4.7
was released shortly after the most recent version of this add-on. For any users choosing to bump to3.4.7
instead of3.5
or later (probably not many) or Ember Add-on authors that are testing against a generic3.4
version (probably many), this package should support3.4.7
.The text was updated successfully, but these errors were encountered: