Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package should support Ember 3.4.7 #8

Closed
alexlafroscia opened this issue Dec 13, 2018 · 6 comments
Closed

Package should support Ember 3.4.7 #8

alexlafroscia opened this issue Dec 13, 2018 · 6 comments

Comments

@alexlafroscia
Copy link

It seems like ember-source@3.4.7 was released shortly after the most recent version of this add-on. For any users choosing to bump to 3.4.7 instead of 3.5 or later (probably not many) or Ember Add-on authors that are testing against a generic 3.4 version (probably many), this package should support 3.4.7.

@alexlafroscia alexlafroscia changed the title Does not support Ember 3.4.7 Package should support Ember 3.4.7 Dec 13, 2018
@rwjblue
Copy link

rwjblue commented Dec 13, 2018

Yep, definitely agree.

@alexlafroscia
Copy link
Author

I wanted to take care of fixing this myself, but I'm not sure where the vendor/ember-native-class-polyfill/*.*.*/ files are generated.

If someone can let me know where that comes from (and presumably, how they are doctored) I'm happy to make the PR to close this issue.

@alexlafroscia
Copy link
Author

Note: I think the lack of support here also explains why the tests are failing, since the 3.4.0 scenario in Ember Try is running against the unsupported 3.4.7

@pzuraq
Copy link
Owner

pzuraq commented Dec 13, 2018

The polyfill branches are

It should be possible to rebase the current branch ontop of the latest patch release and rebuild. For the non legacy part of the polyfill, you have to remove all of the ES5 transforms. I can do this later today, but happy to merge if you have time to make a PR.

@alexlafroscia
Copy link
Author

I probably won't have time, to be honest. I have a bunch of work stuff on my plate for today.

buschtoens added a commit to buschtoens/ember-lazy-mount that referenced this issue Dec 14, 2018
@pzuraq
Copy link
Owner

pzuraq commented Dec 14, 2018

Support for 3.4.7 added in v1.0.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants