Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineRun name is not unique #37

Closed
cmoulliard opened this issue Mar 5, 2024 · 2 comments
Closed

PipelineRun name is not unique #37

cmoulliard opened this issue Mar 5, 2024 · 2 comments

Comments

@cmoulliard
Copy link
Contributor

Issue

The PipelineRun name is not unique when we populate the resource using the helm chart

// source: https://github.com/q-shift/qshift-templates/blob/main/qshift/templates/quarkus-application/manifests/helm/build-test-push/templates/03-pipelinerun-quarkus-build-test-push.yaml

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: quarkus-build-test-push
  namespace: {{ .Values.app.namespace }}
  labels:
    {{- include "backstage.labels" . | nindent 4 }}

By consequence, it is not possible within a namespace to create several quarkus applications

@cmoulliard cmoulliard transferred this issue from q-shift/backstage-playground Mar 5, 2024
@cmoulliard
Copy link
Contributor Author

Remark: If we use generateName instead of name then argocd sucks: argoproj/argo-cd#1639.

So, we should instead use as ID the componentID to name the pipelineRun

@cmoulliard
Copy link
Contributor Author

cmoulliard commented Mar 5, 2024

I did a test successfully using as new name name: {{ .Values.app.name }}-build-test-push

Screenshot 2024-03-05 at 12 10 59
Screenshot 2024-03-05 at 12 10 48
Screenshot 2024-03-05 at 12 10 12
Screenshot 2024-03-05 at 12 28 18

cmoulliard added a commit to ch007m/qshift-templates that referenced this issue Mar 5, 2024
cmoulliard added a commit to ch007m/qshift-templates that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant