#1310 existing comment shapes should be load only once #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 31 31
Lines 23448 23448
=======================================
Hits 23090 23090
Misses 239 239
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xuri
approved these changes
Aug 10, 2022
xuri
pushed a commit
to carbin-gun/excelize
that referenced
this pull request
Oct 9, 2022
…os#1311) By load only once for existing comment shapes, improving performance for adding comments in the worksheet
xuri
pushed a commit
to JDavidVR/excelize
that referenced
this pull request
Jul 11, 2023
…os#1311) By load only once for existing comment shapes, improving performance for adding comments in the worksheet
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
…os#1311) By load only once for existing comment shapes, improving performance for adding comments in the worksheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
fix for #1310 : existing comment shapes should be load only once
Description
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist