Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #325, performance optimization for add comments #347

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

BluesJhao
Copy link
Contributor

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Feb 24, 2019

Codecov Report

Merging #347 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #347      +/-   ##
=========================================
+ Coverage   98.79%   98.8%   +<.01%     
=========================================
  Files          19      19              
  Lines        4061    4092      +31     
=========================================
+ Hits         4012    4043      +31     
  Misses         29      29              
  Partials       20      20
Impacted Files Coverage Δ
excelize.go 95.57% <100%> (+0.07%) ⬆️
file.go 90.76% <100%> (+0.93%) ⬆️
comment.go 99.55% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c223815...22460b6. Read the comment docs.

@xuri xuri changed the title Resolve #235, performance optimization for add comments Resolve #325, performance optimization for add comments Feb 24, 2019
@xuri xuri merged commit 1427027 into qax-os:master Feb 24, 2019
@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2020
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants