Handle multi row inline strings #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the tests go back to Go 1.9 and strings.Builder is unavailable. Do we still support Go 1.9? If so I can change that back to string concatenation. |
|
The new version can no longer support Go 1.9. This change will be included in the next version 2.0.2. I suggest simply break compatibility and update README notes. |
The inline string struct is actually the same as the shared strings struct, reuse it. Note that Go version 1.10 is required. Fixes #462
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 96.38% 96.38% +<.01%
==========================================
Files 24 25 +1
Lines 5254 5257 +3
==========================================
+ Hits 5064 5067 +3
Misses 106 106
Partials 84 84
Continue to review full report at Codecov.
|
|
Okay I updated the readme to note that Go 1.10 or higher is required. |
xuri
added
the
size/S
nullfy
pushed a commit
to nullfy/excelize
that referenced
this pull request
Oct 23, 2020
Fixed qax-os#462 Handle multi row inline strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #461 because I added to that unit test so either merge that one first and then this one, or just merge this one and close the other.
Description
Handle multi row inline strings, simplify the row combination logic and use a
string builder.
Related Issue
#462
Motivation and Context
Inline strings, not just shared strings, can have the
rfields. Since the structs matched I went ahead and consolidated them.How Has This Been Tested
Added unit test and verified against the sample file provided in the issue.
Types of changes
Checklist