Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeding time in WebUI #14554

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Seeding time in WebUI #14554

merged 3 commits into from
Mar 22, 2021

Conversation

thalieht
Copy link
Contributor

  • Add seeding time to the active time column in WebUI (like it is in GUI)
  • Fix incorrect seeding time string in WebUI General tab
  • Allow >100 days in WebUI function "friendlyDuration" (and make the statement above the function actually true)

Closes #14526

@thalieht thalieht added the WebUI WebUI-related issues/changes label Mar 15, 2021
@glassez

This comment has been minimized.

Sign in to view
@glassez
Copy link
Member

glassez commented Mar 19, 2021

Please make sure that it does not require upgrading the web API version, or increase it accordingly. It may also depend on what milestone you are targeting it, 4.3.4 or 4.4.

@Chocobo1 Chocobo1 added this to the 4.4.0 milestone Mar 20, 2021
@thalieht
Allow >100 days in WebUI function "friendlyDuration"
d124041 
Because it's not only used for ETA.
@Chocobo1
Copy link
Member

Please make sure that it does not require upgrading the web API version, or increase it accordingly. It may also depend on what milestone you are targeting it, 4.3.4 or 4.4.

@thalieht @glassez
I think this PR should bump the version to 2.8.2 and https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1)#torrent-management should be updated too.
I'm also thinking about moving the milestone to v4.3.x since this PR would not cause disturbance and the version number would be easier to maintain.

@glassez
Copy link
Member

glassez commented Mar 21, 2021

I'm also thinking about moving the milestone to v4.3.x since this PR would not cause disturbance

As I can see API version was bumped to 2.8.1 for v4.3.4 release so it this changes will go in v4.3.4 too you don't need to bump API version again.

@thalieht
Copy link
Contributor Author

I'm also thinking about moving the milestone to v4.3.x

👍
Wiki updated.

@Chocobo1 Chocobo1 modified the milestones: 4.4.0, 4.3.4 Mar 22, 2021
@Chocobo1 Chocobo1 merged commit 87ad8a1 into qbittorrent:master Mar 22, 2021
@Chocobo1
Copy link
Member

@thalieht
Thank you!

@thalieht thalieht deleted the seeding_time_webui branch March 22, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@FranciscoPombal FranciscoPombal FranciscoPombal left review comments

Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.3.4
Development

Successfully merging this pull request may close these issues.

Show seed time
4 participants
@thalieht @glassez @Chocobo1 @FranciscoPombal