Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect comment links fom the WebUI #15251

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Aug 1, 2021

rel=noopener results in better performance and security for untrusted links. Implicit in very-up-to-date browsers, but people still use older browsers through embedded webviews in apps and devices. rel=noreferrer ever so slightly enhances user privacy.

@glassez glassez requested a review from a team August 1, 2021 04:04
@glassez glassez added the WebUI WebUI-related issues/changes label Aug 1, 2021
@Chocobo1
Copy link
Member

Chocobo1 commented Aug 1, 2021

We specified our supported browsers here: https://github.com/qbittorrent/qBittorrent/tree/master/src/webui/www#browser-compatibility
Although within this range some older browser isn't applying the action by default yet the browser will soon be outdated... personally I won't be active to support this PR unless others think it is a necessity.

Implicit in very-up-to-date browsers

Also note that it is in the spec: whatwg/html#4330

Copy link
Member

@Piccirello Piccirello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small change but probably worth it. I suspect there shouldn't be any additional work to support this beyond the initial commit. If the team ultimately decides not to merge this, that's probably ok too.

@Chocobo1 Chocobo1 added this to the 4.4.0 milestone Aug 3, 2021
@Chocobo1 Chocobo1 merged commit 60b1e69 into qbittorrent:master Aug 3, 2021
@Chocobo1
Copy link
Member

Chocobo1 commented Aug 3, 2021

@da2x
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants