-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce referrer-policy in WebUI #9993
Conversation
Have you considered adding the ‘Referrer-Policy’ header instead? It would allow us to avoid modifying all html files. |
OK, will change. |
This stops leaking private data to other websites via Referrer header.
I’d probably leave it enabled for the alt WebUI until someone requested otherwise (which may not happen). But we can always add another checkbox to the options 😄 |
yeah, however I still think it is best not block their way in the first place, personally I would just give up and quit instead of filing an issue about it.
I think this is too much... I'm not trying to write a feature complete web server 😓 |
I think there's two options then, as I see it:
Edit: I see you already updated to option 2. Hadn't even noticed! |
e7f8f9a
to
c9b0658
Compare
The majority of the CSP is tuned for built-in WebUI, it may not be suitable for alternative UI. Also add QLatin1String to strings. This code path is called repeatedly, it is worth adding QLatin1String to squeeze out the last bit of performance.
Thanks for reviewing! |
This stops leaking private data to other websites via Referrer header.
@Piccirello
I might merge this before your other PRs, so you'll need to add the line to the new file in #9375.