Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight validation errors #275

Closed
Stephen-Gates opened this issue Dec 2, 2017 · 5 comments
Closed

Highlight validation errors #275

Stephen-Gates opened this issue Dec 2, 2017 · 5 comments
Labels
f:Feature-request This issue is a request for a new feature fn:Validation priority:High
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Dec 2, 2017

Desired Behaviour (for feature requests only)

screenshot 2017-12-02 13 35 02

@Stephen-Gates Stephen-Gates added f:Feature-request This issue is a request for a new feature fn:Validation labels Dec 2, 2017
@Stephen-Gates Stephen-Gates added this to the v1.x.x milestone Dec 2, 2017
@Stephen-Gates
Copy link
Contributor Author

Adjust error message at Home.vue #L97 to include columnNumber, e.g.

              <h3>{{messagesTitle}}</h3>
              <template  v-if="messagesType === 'error'">
                <div v-for="errorMessage in messages">
                  <span v-show="errorMessage.rowNumber">Row {{errorMessage.rowNumber}}, </span>
                  <span v-show="errorMessage.columnNumber"> Column {{errorMessage.columnNumber}}, </span>
                  <span>{{errorMessage.message}}</span>
                </div>
              </template>

Potentially include hyperlink in rowNumber, columnNumber to cell in table (see #280)

@ghost
Copy link

ghost commented Jan 17, 2018

So we could:

  • use hot's comments to add the markers
  • they can stay until someone re-validates

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Jan 17, 2018

From #388 consider highlighting cell and adding error message as comment - https://docs.handsontable.com/0.35.0/demo-comments_.html#example

Bottom Status bar remains a list of errors (perhaps with a total number of errors found)

With #280, each error message would contain a hyperlink that, when clicked, would move the cursor to the cell in error and scroll the data table so that cell was visible on the screen.

image

@Stephen-Gates
Copy link
Contributor Author

Watch for progress on frictionlessdata/datapackage#364

@Stephen-Gates
Copy link
Contributor Author

Works 🎉

screenshot 2018-03-21 19 59 53

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:Feature-request This issue is a request for a new feature fn:Validation priority:High
Projects
None yet
Development

No branches or pull requests

1 participant