Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable entry of groupChar for Number data type #745

Closed
Stephen-Gates opened this issue Apr 30, 2018 · 4 comments
Closed

Enable entry of groupChar for Number data type #745

Stephen-Gates opened this issue Apr 30, 2018 · 4 comments
Labels
f:Feature-request This issue is a request for a new feature fn:Set-Properties priority:Medium
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Enable entry of groupChar for number data type.

See #374

@ghost
Copy link

ghost commented May 2, 2018

Use quote to show the character (important if the character is space or null)
Keep quote consistent with that used in enum.

@ghost
Copy link

ghost commented May 9, 2018

Hi @Stephen-Gates
Not 100% sure yet, but I'm going to issue a ticket in frictionless as I think it doesn't allow space, " ", as a valid group Char separator - as far as I can tell the frictionless spec should allow it. Can still work on this ticket and close off, but what it might mean is that numbers with spaces will just be allowed through (even when the default is set which is nothing or "").

@ghost
Copy link

ghost commented May 9, 2018

Testing seems to confirm. Before I send this as issue to frictionless (and so I can get on with this sprint release), @Stephen-Gates , I've been looking at:
https://frictionlessdata.io/specs/table-schema/#number
https://www.w3.org/TR/xmlschema-2/#decimal
https://www.w3.org/TR/xmlschema-2/#rf-whiteSpace
From what I can see, number is an atomic type, so whitespace should apply (with property collapse)? But then it also says that number (decimal from W3 spec) is:
finite-length sequence of decimal digits (#x30-#x39)
I note also that frictionless departs from W3 spec a bit as it allows leading trailing zeros whereas W3spec doesn't, but insists there must be digit on either side of decimal char.
Just thought I should check with you first, before putting pull request in.

A guide that provides step-by-step instructions for improving your data publishing workflow using Frictionless Data software

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented May 9, 2018

@mattRedBox I’d add an issue as well as a pr. You probably won’t get a reply until tonight and discussion may follow before pr is accepted. Is the pr just to support space? Alternatively we could propose non-space Character in spec

ghost pushed a commit that referenced this issue May 9, 2018
ghost pushed a commit that referenced this issue May 9, 2018
ghost pushed a commit that referenced this issue May 9, 2018
@ghost ghost closed this as completed May 9, 2018
ghost pushed a commit that referenced this issue Apr 21, 2021
ghost pushed a commit that referenced this issue Apr 21, 2021
ghost pushed a commit that referenced this issue Apr 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:Feature-request This issue is a request for a new feature fn:Set-Properties priority:Medium
Projects
None yet
Development

No branches or pull requests

1 participant