Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign keys being not being saved as an element of the schema #972

Closed
pripley123 opened this issue Dec 16, 2019 · 4 comments
Closed

Foreign keys being not being saved as an element of the schema #972

pripley123 opened this issue Dec 16, 2019 · 4 comments
Labels
est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) problem:Bug A bug severity:Moderate support This issue is a candidate to complete under the support agreement

Comments

@pripley123
Copy link

Current Behaviour (for problems)

Data Curator is storing the foreign key and primary key relationships as an element of the resource as opposed to part of the schema element

Expected Behaviour

The foreign key relationship should be an element of the schema

Steps to Reproduce

  1. Import two comma separated csv's
  2. create a foreign key relationship between csvs
  3. fill out information needed to allow data package to be exported
  4. export data package
  5. open data package's datapackage.json
  6. the foreign key relationship is stored as an element of the resource

Your Environment

Windows

  • Data Curator version: 1.1
@ghost
Copy link

ghost commented Apr 22, 2020

Hi @pripley123
I must admit it has been a little while since I checked, but my understanding was that we follow the frictionless specification for table schema.
Ah yes, I can see that we've slipped that 1 place too high - I can look at where this is being done.

@ghost
Copy link

ghost commented Apr 22, 2020

Reference with example:
frictionlessdata/datapackage-js#90

@ghost ghost added est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) severity:Moderate problem:Bug A bug labels Apr 22, 2020
@ghost
Copy link

ghost commented Apr 22, 2020

Frictionless spec handled correctly it seems (and possibly importing as both table props and schema props are imported as DataCurator doesn't use 'schema' as a key in properties) - possibly just need to change for export and consider test coverage.

@ghost ghost added the support This issue is a candidate to complete under the support agreement label Apr 23, 2020
@ghost ghost added this to the Support release 2 milestone May 9, 2020
@ghost ghost closed this as completed in 9565f71 May 11, 2020
@ghost
Copy link

ghost commented May 18, 2020

Noticed some to-dos with review of updates to frictionless table: logged in #1009

ghost pushed a commit that referenced this issue Apr 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) problem:Bug A bug severity:Moderate support This issue is a candidate to complete under the support agreement
Projects
None yet
Development

No branches or pull requests

1 participant