Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send client and java version to server #59

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Send client and java version to server #59

merged 3 commits into from
Dec 10, 2024

Conversation

tellet-q
Copy link
Contributor

  • Add additional info on client and java version to user-agent: "user-agent": "java-client/v1.12.0 java/21.0.5 grpc-java-netty/1.56.0"
  • Set user-agent during channel creation

Anush008
Anush008 reviewed Dec 10, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@tellet-q tellet-q requested a review from Anush008 December 10, 2024 11:37
Anush008
Anush008 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@tellet-q tellet-q merged commit 593a397 into master Dec 10, 2024
1 check passed
@tellet-q tellet-q deleted the client-version-to-server branch December 10, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anush008 Anush008 Anush008 approved these changes

@agourlay agourlay Awaiting requested review from agourlay

@generall generall Awaiting requested review from generall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tellet-q @Anush008