renamed recommend_batch to recommendBatch for consistency and kept alias #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for this PR! And also thanks for the backward compatibility using aliases. I merged it into upcoming |
Merged
IvanPleshkov
added a commit
that referenced
this pull request
Dec 8, 2023
* update grpc * update generated_schema * provide timeout to api * create shards api * shard keys public api * discovery api * add new fields * v1.7.0 * update proto (#57) * update undici * fix unit tests * renamed recommend_batch to recommendBatch for consistency and kept alias (#54) Co-authored-by: Mohamed Morad <mohamed.morad@syncore.at> Co-authored-by: Ivan Pleshkov <pleshkov.ivan@gmail.com> * fix ci * restore tests * add comments to new api * shard_key args docs * create collection docs * qdrant integration tests version up * thanks to Morad-m11 --------- Co-authored-by: Morad-m11 <80397392+Morad-m11@users.noreply.github.com> Co-authored-by: Mohamed Morad <mohamed.morad@syncore.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.