Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changes trie #1292

Merged
merged 21 commits into from
Aug 1, 2022
Merged

Remove changes trie #1292

merged 21 commits into from
Aug 1, 2022

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Jul 29, 2022

Referenced issues

#1283

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from Harrm and GaroRobe July 29, 2022 13:03
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1292 (cd25bdc) into master (1f859e5) will increase coverage by 0.01%.
The diff coverage is 17.85%.

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
+ Coverage   25.83%   25.85%   +0.01%     
==========================================
  Files         595      592       -3     
  Lines       21699    21568     -131     
  Branches    11216    11128      -88     
==========================================
- Hits         5607     5576      -31     
+ Misses      10967    10915      -52     
+ Partials     5125     5077      -48     
Impacted Files Coverage Δ
core/api/service/impl/api_service_impl.cpp 13.26% <ø> (ø)
core/api/service/impl/api_service_impl.hpp 23.80% <ø> (ø)
core/consensus/grandpa/impl/voting_round_impl.cpp 24.05% <0.00%> (-0.04%) ⬇️
core/host_api/impl/host_api_factory_impl.cpp 73.33% <ø> (+0.60%) ⬆️
core/host_api/impl/host_api_factory_impl.hpp 100.00% <ø> (ø)
core/host_api/impl/host_api_impl.hpp 100.00% <ø> (ø)
core/primitives/digest.hpp 41.66% <ø> (+5.95%) ⬆️
core/primitives/event_types.hpp 41.17% <ø> (ø)
core/runtime/runtime_api/impl/core.cpp 17.85% <0.00%> (ø)
core/storage/changes_trie/changes_tracker.hpp 100.00% <ø> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit a864be4 into master Aug 1, 2022
@turuslan turuslan deleted the remove/changes-trie branch August 1, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants