Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'prune-discarded' mode #1702

Merged
merged 6 commits into from
Jul 24, 2023
Merged

'prune-discarded' mode #1702

merged 6 commits into from
Jul 24, 2023

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Jul 18, 2023

Referenced issues

Description of the Change

Benefits

Trie pruner can be disabled completely.

Possible Drawbacks

None expected.

@Harrm Harrm self-assigned this Jul 18, 2023
@Harrm Harrm marked this pull request as ready for review July 19, 2023 21:49
@Harrm Harrm requested review from turuslan and kamilsa July 20, 2023 08:07
@Harrm Harrm force-pushed the feature/prune-discarded-mode branch from a57d936 to 6193c78 Compare July 24, 2023 12:47
return std::nullopt;
}
};
} // namespace kagome::storage::trie_pruner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line?

@Harrm Harrm enabled auto-merge (squash) July 24, 2023 13:51
@Harrm Harrm merged commit 7bb48a4 into master Jul 24, 2023
10 of 16 checks passed
@Harrm Harrm deleted the feature/prune-discarded-mode branch July 24, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants