Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl config #1905

Merged
merged 3 commits into from
Dec 29, 2023
Merged

ssl config #1905

merged 3 commits into from
Dec 29, 2023

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Dec 21, 2023

Referenced issues

Description of the Change

  • Use suggested secure ssl config.
  • Don't close tcp connection before http response received.

Benefits

Possible Drawbacks

  • Sets SSL_CERT_FILE=/etc/ssl/cert.pem if SSL_CERT_FILE/SSL_CERT_DIR are empty and /etc/ssl/cert.pem exists.

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
cmake/functions.cmake Outdated Show resolved Hide resolved
Comment on lines +30 to +32
set_options(context::default_workarounds | context::no_sslv2
| context::no_sslv3 | context::no_tlsv1 | context::no_tlsv1_1
| context::no_tlsv1_2 | context::single_dh_use);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so strict.. Okay

@turuslan turuslan enabled auto-merge (squash) December 29, 2023 09:03
@turuslan turuslan merged commit a0dd372 into master Dec 29, 2023
10 checks passed
@turuslan turuslan deleted the audit/20 branch December 29, 2023 09:10
@turuslan turuslan mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants