Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Refactored Docker Image Build for CI:
• Rewrote the Docker image build process to enhance CI efficiency and consistency.
Container Save Step:
• Integrated a step to save containers into our infrastructure.
Tag-based Deployment:
• Implemented logic to push images to the repository with a tag if the commit has one. This applies both to the Git repository and Docker registry.
Docker Tag Naming for Main Branch:
• For the main branch, the Docker image tag will follow the pattern <short_commit_tag>-master. This needs verification to ensure correct implementation.
Future Repository Management:
• The tagging scheme will potentially allow filtering and cleaning old builds from the repository in the future.
CI and Helm Chart Changes:
• Updated the CI pipeline and Helm charts. The current version for our images is 0.0.0-rc.26.
Container Name Uniqueness:
• Changed container naming convention for better log filtering. The new format is {{ $appName }}-{{ $nodeChain }}-{{ .Values.image.tag }}.
Removal of Tini Download Step:
• Removed the Helm chart step where Tini was downloaded, as it is now included in the container image. Consequently, the new chart is incompatible with older containers. For those requiring the old setup, continue using version 0.0.0-rc.24 (where Tini is not included in the image).
Security Improvement:
• Made a minor enhancement in credential handling during the container build process to eliminate potential security issues.
Possible Drawbacks
• Compatibility Check: Ensure that the new Helm chart is used only with the updated containers that include Tini.
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: