Fix payment_queryInfo #2188
Merged
Fix payment_queryInfo #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
commented
Aug 20, 2024
| @@ -110,10 +110,6 @@ namespace kagome::host_api { | |||
| storage_type = StorageType::Persistent; | |||
| } else if (kind == 2) { | |||
| storage_type = StorageType::Local; | |||
| } else if (kind == 0) { | |||
Harrm
approved these changes
Aug 20, 2024
This reverts commit 3340f38.
Co-authored-by: Harrm <abrehchs@gmail.com>
xDimon
approved these changes
Aug 21, 2024
| @@ -16,6 +16,8 @@ OUTCOME_CPP_DEFINE_CATEGORY(kagome::runtime, | |||
| switch (err) { | |||
| case E::TRANSACTION_PAYMENT_API_NOT_FOUND: | |||
| return "Transaction payment runtime API is not found in the runtime"; | |||
| case TransactionPaymentApiImpl::Error::API_BELOW_VERSION_2_NOT_SUPPORTED: | |||
There was a problem hiding this comment.
Suggested change
| case TransactionPaymentApiImpl::Error::API_BELOW_VERSION_2_NOT_SUPPORTED: | |
| case E::API_BELOW_VERSION_2_NOT_SUPPORTED: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Closes #2183
Description of the Change
Fixes payment_queryInfo, for compatibility with e.g. Nova wallet
Possible Drawbacks
Older versions of query_info runtime api is now obsolete
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: