Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precompilation for Glutton parachain #2198

Merged
merged 18 commits into from
Sep 2, 2024
Merged

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Aug 29, 2024

… also minor code cleanups

Referenced issues

Description of the Change

Zombienet test 0013 uses Glutton parachain, which requires modification in the precompilation script.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review August 29, 2024 12:14
@Harrm Harrm requested review from xDimon and turuslan August 29, 2024 12:14
core/parachain/CMakeLists.txt Outdated Show resolved Hide resolved
core/application/modes/precompile_wasm.cpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_worker_types.hpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Outdated Show resolved Hide resolved
zombienet/precompile.sh Show resolved Hide resolved
@Harrm Harrm merged commit 2b530f8 into master Sep 2, 2024
19 of 21 checks passed
@Harrm Harrm deleted the fix/0013-precompilation branch September 2, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants