Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to boost 1.85 #2244

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Downgrade to boost 1.85 #2244

merged 3 commits into from
Oct 16, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Oct 16, 2024

Referenced issues

#2245 should be taken into work after this PR

Description of the Change

  • Upgrading to boost 1.86.0 lead to Kagome crashes on westend and kusama (read [Enhancement]: Upgrade to Boost 1.86.0 #2245 for more details). Therefore we are temporary downgrading KAGOME to previous boost version
  • Upgrading libp2p to c96d45f792fafd6970a7e37ec816b02a9167e2b6 (yamux fix)

Possible Drawbacks

Not up to date boost

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review October 16, 2024 12:59
@kamilsa kamilsa enabled auto-merge (squash) October 16, 2024 13:07
@kamilsa kamilsa merged commit 21ce1bc into master Oct 16, 2024
16 of 21 checks passed
@kamilsa kamilsa deleted the fix/downgrade-boost branch October 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants