Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunks are held on rocksdb for 25 hours #2252

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

ErakhtinB
Copy link
Contributor

Referenced issues

Closes #1948

Description of the Change

Rocksdb instance is changed to ttl one. avaliability_storage is the first column with non-zero ttl to store parachain data for at least 25 hours. Other columns are configured with 0 ttl, so it ttl logic is not applied to them.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@ErakhtinB ErakhtinB linked an issue Oct 29, 2024 that may be closed by this pull request
@ErakhtinB ErakhtinB requested review from iceseer, xDimon and igor-egorov and removed request for xDimon October 29, 2024 10:30
Comment on lines 24 to 26
static Key encode(const std::pair<parachain::CandidateHash,
parachain::ChunkIndex> &candidateChunk) {
Key key;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

то что тут 1 объект никак не используется. Формируются в ключе поля отдельно. Создание промежуточной пары лишнее.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ErakhtinB ErakhtinB force-pushed the 1948-ensure-parachains-data-is-temporary-stored branch from 65a1c26 to 02955ff Compare November 1, 2024 10:02
@ErakhtinB ErakhtinB force-pushed the 1948-ensure-parachains-data-is-temporary-stored branch from 02955ff to 4d5bed5 Compare November 4, 2024 02:01
@ErakhtinB ErakhtinB enabled auto-merge (squash) November 4, 2024 02:01
@ErakhtinB ErakhtinB merged commit 8a593bb into master Nov 4, 2024
11 of 12 checks passed
@ErakhtinB ErakhtinB deleted the 1948-ensure-parachains-data-is-temporary-stored branch November 4, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure parachains data is temporary stored
3 participants