Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Globe plugin #36604

Merged
merged 1 commit into from
May 24, 2020
Merged

Drop Globe plugin #36604

merged 1 commit into from
May 24, 2020

Conversation

espinafre
Copy link
Contributor

@espinafre espinafre commented May 21, 2020

Dropping Globe plugin from the QGIS sources. It depends on osgearth no
newer than version 2.8, released on 2016-09-05, and which is impossible
to build against modern (Qt 5.13+) versions of Qt. With this, the
optional QGIS dependency on OpenSceneGraph and osgearth is also removed.

I've asked the qgis-developers mailing list, and some of the original authors agreed with the change:

https://lists.osgeo.org/pipermail/qgis-developer/2020-May/061298.html

There, @wonder-sk pointed out that most of its functionality is provided by the 3D view.

This removes all references to the Globe plugin, openscenegraph and osgearth, including CMake macros and options.

I believe this shoult NOT be backported to LTR, as there might be someone still using it (but it is disabled by default on all platform configurations).

Dropping Globe plugin from the QGIS sources. It depends on osgearth no
newer than version 2.8, released on 2016-09-05, and which is impossible
to build against modern (Qt 5.13+) versions of Qt. With this, the
optional QGIS dependency on OpenSceneGraph and osgearth is also removed.
@nyalldawson
Copy link
Collaborator

+1

If we do it now it gives users who require the missing "globe" mode in the native 3d framework time to find this last feature gap before the next ltr.

@nirvn
Copy link
Contributor

nirvn commented May 24, 2020

Seems we're all in agreement here. Who wants to push the button?

@nyalldawson nyalldawson added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label May 24, 2020
@qgis-bot
Copy link
Collaborator

@espinafre
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@espinafre
A documentation ticket has been opened at qgis/QGIS-Documentation#5544
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants