Set max_largest_intermediate for hybridq
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30. Apparently there is a
max_largest_intermediateoption in hybridq'ssimulatewhich is relevant for their tensor network simulator but, at least according to the documentation, is only used to raise an error for the state vector simulator. Here I hardcode a very high value (40 qubits) in this parameter so that we never get the error. I tried on qibomachine CPU and it works now, previously I was getting the same error. @mlazzarin can you also try with your examples?By the way, I have not checked in detail where this value is used in their code, so I am not sure if setting it to a very high number has any effect in performance when simulating smaller circuits.