Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redbiom returning wrong number of artifacts #2569

Closed
adswafford opened this issue Apr 23, 2018 · 9 comments
Closed

Redbiom returning wrong number of artifacts #2569

adswafford opened this issue Apr 23, 2018 · 9 comments

Comments

@adswafford
Copy link
Contributor

When searching with Redbiom, the number of artifacts returned can greatly exceed the logical number necessary to access for the sample(s) searched for.

Steps to reproduce:

  1. Go to qiita.ucsd.edu/redbiom
  2. Enter "where anonymized_name == '000065978' "
  3. Result:
    image
@antgonza
Copy link
Member

Right, that number is showing the total number of artifacts in the study vs. how many have that sample ...

@adswafford
Copy link
Contributor Author

Shouldn't it just show the number of artifacts with the sample? And likely the retrieval of all the artifacts is contributing to #2571 right?

@antgonza
Copy link
Member

Agree, should be the number of artifacts with that sample

@antgonza
Copy link
Member

I'm trying to figure out how to solve this and realized that I need some help from @wasade, asking here in case that we need input from others on how to better display the info or where to solve but happy to move to PM.

Anyway, in the specific example @adswafford used, we are basically looking in the sample template for anonymized_name == '000065978', which in praxis it applies to all artifact/samples; however, ideally, we will only return the artifacts where this value exists. Another example for clarity, let's imagine that we have 2 preps, one with stool and another with oral; if we look for fecal in the sample info file both artifacts will be found (cause both have fecal in their sample info file).

Thoughts?

@antgonza
Copy link
Member

ping @wasade

@wasade
Copy link
Contributor

wasade commented Aug 23, 2018 via email

@antgonza
Copy link
Member

Ha! Just realized that my example can be confusing, sorry! The idea here is that in a study X, with prep A (artifact a) and prep B (artifact b) and a sample with anonymized_name == '000065978' in prep A; if you search for anonymized_name == '000065978', that will return study X but it will not give you that it only exists in prep A (artifact a). Please PM if this doesn't make sense.

Anyway, the point is that I'm not sure if redbiom can actually return the prep or artifact where anonymized_name == '000065978' is found. Obviously, we can recover this info within Qiita but just wondering if better/faster via redbiom as currently qiita will use SQL queries to figure it out.

@wasade
Copy link
Contributor

wasade commented Aug 23, 2018 via email

@antgonza antgonza modified the milestones: Nov 2018 Update, Jan 2019 Dec 7, 2018
@adswafford
Copy link
Contributor Author

Confirmed on Jan 8 2019 that this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants