Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample update with no new samples or colums will fail silently #2806

Closed
antgonza opened this issue Jan 29, 2019 · 0 comments
Closed

sample update with no new samples or colums will fail silently #2806

antgonza opened this issue Jan 29, 2019 · 0 comments

Comments

@antgonza
Copy link
Member

This is an issue if we are trying to update the information without adding any new samples or metadata columns. The hack solution is to remove a column and then update the sample info file.

The issue is _common_extend_steps

            if not new_cols and not new_samples:
                return

it should be:

            if not new_cols and not new_samples:
                return None, None

cc: @ackermag

@antgonza antgonza added this to the Mar 2019 milestone Jan 29, 2019
@antgonza antgonza changed the title sample update with no new samples or calls will fail silently sample update with no new samples or colums will fail silently Jan 31, 2019
antgonza added a commit that referenced this issue Feb 24, 2019
* fix #2809, fix #2806

* flake8

* fix errors

* redbiom.util.ids_from exact True->False

* print to debug

* print to debug

* print to debug

* fix tests

* cosmetic updates to

* added deblur feature search example

* update taxonomy search example

* fixing documentation

* addressing @charles-cowart commets

* fix log in

* letters -> ascii_letters

* fix redbiom

* 4 -> '4'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant