Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Searching..." bar or text when search is ongoing #3119

Closed
mestaki opened this issue Jun 25, 2021 · 3 comments
Closed

Add a "Searching..." bar or text when search is ongoing #3119

mestaki opened this issue Jun 25, 2021 · 3 comments

Comments

@mestaki
Copy link
Collaborator

mestaki commented Jun 25, 2021

Reproduce the issue:
From the main "View Studies" page, search for a term like "Paulus". It takes about ~7-10 seconds for the page to start showing the results, during which time no indication is made that search is ongoing. This leads to user thinking the search has returned 0 results and they move on to the next search item before the previous search is complete. I suspect this issue will become exaggerated as more data is added and searches take longer.

Propose behavior:

  1. Show a "Loading" bar or text when a search is still ongoing, or
  2. Add a "Search" button beside the search field that users click that goes dim when a search is ongoing.
@antgonza
Copy link
Member

@mestaki; thank you for your suggestion - you are right about time and what's going on in the system. As an example, I added a 5 second delay in my local test to simulate what's going on; basically, if you type something that you expect datatables says is not found because the list hasn't being loaded, like this:
issue-3119

As you suggested, there is an option in datatables that will show that the data is being processed (downloading) which is basically a little frame on top of the other messages, like this:
issue-3119-fix.

Will this work? Anyway, here is the PR in case you have specific suggestions about language.

@mestaki
Copy link
Collaborator Author

mestaki commented Nov 1, 2021

Hey @antgonza,
Awesome this is perfect! Glad it wasn't too much of a hassle to change :)

mestaki added a commit that referenced this issue Nov 1, 2021
@antgonza
Copy link
Member

antgonza commented Nov 1, 2021

Thank you for your feedback and review - this will be deployed during this cycle (in a few weeks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants