Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_qiita_version should store and retrieve information from redis #3216

Closed
antgonza opened this issue Oct 17, 2022 · 1 comment
Closed

get_qiita_version should store and retrieve information from redis #3216

antgonza opened this issue Oct 17, 2022 · 1 comment
Milestone
Confirmed issues ...

Comments

@antgonza
Copy link
Member

Currently, every time a page gets displayed we check the current git version of the qiita code via "get_qiita_version", which uses GitPython. The issue is that it actually uses Popen to do this operation which means that it issues a new command every time, which is less than ideal.
@antgonza
Copy link
Member Author

While looking on how to fix this, I found this comment: https://github.com/gitpython-developers/GitPython#leakage-of-system-resources

@antgonza antgonza mentioned this issue Oct 31, 2022
Merged
charles-cowart added a commit that referenced this issue Oct 31, 2022
@charles-cowart
Merge pull request #3217 from antgonza/general-fixes
330ff8a 
fix #3216 + other smaller fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Confirmed issues or feature requests
Development

No branches or pull requests
1 participant
@antgonza