fix #3089 #3097
Merged
fix #3089 #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adswafford
suggested changes
Apr 28, 2021
|
|
||
| if ((count_ok || (!is_required && num_children === 0))) { | ||
| if ($("#artifact-type").val() === 'per_sample_FASTQ' && num_samples !== num_children) { | ||
| message = "per_sample_FASTQ expects the same number of samples and run_prefix."; |
There was a problem hiding this comment.
Maybe a slightly altered message to be clearer:
per_sample_FASTQ expects one run_prefix per sample. Check for duplicate or missing run_prefix entries.
wasade
approved these changes
Apr 28, 2021
| mark_as_correct(this); | ||
|
|
||
| if ((count_ok || (!is_required && num_children === 0))) { | ||
| if ($("#artifact-type").val() === 'per_sample_FASTQ' && num_samples !== num_children) { |
There was a problem hiding this comment.
Suggested change
| if ($("#artifact-type").val() === 'per_sample_FASTQ' && num_samples !== num_children) { | |
| if (($("#artifact-type").val() === 'per_sample_FASTQ') && (num_samples !== num_children)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra from blocking, I added the possibility of showing a message so users have a better idea of why is blocked.