Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve loading times of studies #3350

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

antgonza
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jan 26, 2024

Coverage Status

coverage: 92.841% (-0.001%) from 92.842%
when pulling f58de06 on antgonza:improve-loading-times
into 379caa5 on qiita-spots:dev.

@antgonza
Copy link
Member Author

I deployed this PR in qiita-rc and here are some times for comparison:

  • qiita (12 secs):
[I 240126 06:49:49 web:2161] 200 GET /study/description/10317 (127.0.0.1) 4605.34ms
[I 240126 06:49:53 web:2161] 200 GET /study/description/data_type_menu/?study_id=10317 (127.0.0.1) 3099.71ms
[I 240126 06:49:54 web:2161] 200 GET /study/description/baseinfo/?study_id=10317 (127.0.0.1) 4378.46ms
  • qiita-rc same version than in qiita (13.2 secs):
[I 240126 14:23:22 web:2161] 200 GET /study/description/10317 (127.0.0.1) 4541.17ms
[I 240126 14:23:27 web:2161] 200 GET /study/description/data_type_menu/?study_id=10317 (127.0.0.1) 3688.98ms
[I 240126 14:23:29 web:2161] 200 GET /study/description/baseinfo/?study_id=10317 (127.0.0.1) 5017.63ms
  • this version (6.3 secs):
[I 240129 09:20:10 web:2161] 304 GET /study/description/10317 (127.0.0.1) 2414.34ms
[I 240129 09:20:11 web:2161] 304 GET /study/description/data_type_menu/?study_id=10317 (127.0.0.1) 973.19ms
[I 240129 09:20:13 web:2161] 200 GET /study/description/baseinfo/?study_id=10317 (127.0.0.1) 2961.27ms

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@charles-cowart charles-cowart merged commit 4d0d8bf into qiita-spots:dev Jan 29, 2024
4 checks passed
@antgonza antgonza linked an issue Jan 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve study loading pages
3 participants