Skip to content

Commit

Permalink
Rollup merge of rust-lang#131644 - RalfJung:win-miri, r=joboet
Browse files Browse the repository at this point in the history
Clean up some Miri things in `sys/windows`

- remove miri hack that is only needed for win7 (we don't support win7 as a target in Miri)
- remove outdated comment now that Miri is on CI
  • Loading branch information
matthiaskrgr authored Oct 13, 2024
2 parents 1799481 + e3f701c commit 87ea4bb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion std/src/sys/pal/windows/c.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ extern "system" {
pub fn WakeByAddressAll(address: *const c_void);
}

// These are loaded by `load_synch_functions`.
#[cfg(target_vendor = "win7")]
compat_fn_optional! {
crate::sys::compat::load_synch_functions();
pub fn WaitOnAddress(
address: *const c_void,
compareaddress: *const c_void,
Expand Down
8 changes: 2 additions & 6 deletions std/src/sys/pal/windows/compat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,10 @@ macro_rules! compat_fn_with_fallback {

/// Optionally loaded functions.
///
/// Actual loading of the function defers to $load_functions.
/// Relies on the functions being pre-loaded elsewhere.
#[cfg(target_vendor = "win7")]
macro_rules! compat_fn_optional {
($load_functions:expr;
$(
($(
$(#[$meta:meta])*
$vis:vis fn $symbol:ident($($argname:ident: $argtype:ty),*) $(-> $rettype:ty)?;
)+) => (
Expand All @@ -221,9 +220,6 @@ macro_rules! compat_fn_optional {

#[inline(always)]
pub fn option() -> Option<F> {
// Miri does not understand the way we do preloading
// therefore load the function here instead.
#[cfg(miri)] $load_functions;
NonNull::new(PTR.load(Ordering::Relaxed)).map(|f| unsafe { mem::transmute(f) })
}
}
Expand Down
1 change: 0 additions & 1 deletion std/src/sys/pal/windows/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ pub fn abort_internal() -> ! {
}
}

// miri is sensitive to changes here so check that miri is happy if touching this
#[cfg(miri)]
pub fn abort_internal() -> ! {
crate::intrinsics::abort();
Expand Down

0 comments on commit 87ea4bb

Please sign in to comment.