This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
fill MXJob structure #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houz42
reviewed
May 29, 2018
There was a problem hiding this comment.
jobSpec 要不要考虑参考这个设计，https://github.com/kubeflow/community/blob/master/proposals/tf-operator-design-v1alpha2.md#ui-or-api
最终的yml废话少一些，而且更容易针对不同的replica做接口限制。比如 mxnet 的 scheduler 只能有一个，很多选项也不能随意设定，用map[replicaName]replicaSpec形式的接口要比用现在的 []replicaSpec实现这些限制更方便。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.