Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mssql and postgres connect error #606

Merged
merged 6 commits into from
Jul 16, 2018
Merged

Conversation

xxh2000
Copy link
Contributor

@xxh2000 xxh2000 commented Jul 14, 2018

Fixes #605

Changes

  • feature1
  • feature2
  • fixbug1
  • fixbug2

Reviewers

  • @[someone] please review
  • @[someotherone] please review

Wiki Changes

  • options1...
  • options2...

Checklist

  • Rebased/mergeable
  • Tests pass
  • Wiki updated

@xxh2000 xxh2000 changed the title fix mssql connect error fix mssql and postgres connect error Jul 14, 2018
@wonderflow
Copy link
Contributor

getConnectStr 可以加个单测吗,防止此类情况再次发生。

感谢!

@redHJ
Copy link
Collaborator

redHJ commented Jul 15, 2018

lgtm,谢谢

@wonderflow wonderflow merged commit 2eff924 into qiniu:master Jul 16, 2018
@xxh2000
Copy link
Contributor Author

xxh2000 commented Jul 16, 2018

@wonderflow 是应该加个测试用例验证一下,我有空加个

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

连接sqlserver失败
3 participants