修复mysql meta文件记录出错可能存在重启后重复读取数据的问题 #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
reviewed
Jul 23, 2018
| @@ -489,17 +507,17 @@ func (dbRecords *SyncDBRecords) restoreRecordsFile(meta *reader.Meta) (lastDB, l | |||
| return lastDB, lastTable, true | |||
| } | |||
|
|
|||
| omitDoneDBRecords = true | |||
There was a problem hiding this comment.
默认不是false吗？true的时候你直接return了
There was a problem hiding this comment.
因为现在出错的时候会continue，不是直接return true了
reader/sql/sql_test.go
Outdated
| mrCron.SyncMeta() | ||
| mrCron.Close() | ||
| //mrCron.SyncMeta() | ||
| //mrCron.Close() |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta重复记录问题修复
@wonderflow