Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add re-run #281

Merged
merged 1 commit into from
Aug 24, 2024
Merged

feat:add re-run #281

merged 1 commit into from
Aug 24, 2024

Conversation

never112
Copy link
Contributor

image

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 835eaa4
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/66c8162a491b530008b323c6

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 36.92%. Comparing base (c990e34) to head (835eaa4).
Report is 2 commits behind head on master.

Files Patch % Lines
server.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   37.22%   36.92%   -0.31%     
==========================================
  Files          21       21              
  Lines        1585     1598      +13     
==========================================
  Hits          590      590              
- Misses        931      944      +13     
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}
var pevent = github.PullRequestEvent{}
pevent.Repo = event.GetRepo()
pevent.PullRequest = event.GetCheckRun().PullRequests[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequests 什么情况下会多个?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A分支,同一个commit 向B,C 分支提交PR,创建的check run,就会是同一个, 这时候 这个checkrun 获取的到的pullrequests 就会是多个。 checkrun的创建需要一个必填参数head-sha :the SHA of the commit, 这两次的创建的check run head-sha 会是相同的
https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run

Uploading image.png…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那应该是能精确判断,本次重试是哪个PR吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是关联多个PR的话 是没法确定重试的是那个PR, 多个PR下的checkrun其实就是同一个。

server.go Outdated Show resolved Hide resolved
@never112 never112 force-pushed the zhou0822 branch 3 times, most recently from 08e565c to 0c83184 Compare August 23, 2024 03:05
@CarlJi CarlJi merged commit a4741fc into qiniu:master Aug 24, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants