-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add re-run #281
feat:add re-run #281
Conversation
never112
commented
Aug 22, 2024
✅ Deploy Preview for reviewbot-x canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 37.22% 36.92% -0.31%
==========================================
Files 21 21
Lines 1585 1598 +13
==========================================
Hits 590 590
- Misses 931 944 +13
Partials 64 64 ☔ View full report in Codecov by Sentry. |
} | ||
var pevent = github.PullRequestEvent{} | ||
pevent.Repo = event.GetRepo() | ||
pevent.PullRequest = event.GetCheckRun().PullRequests[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequests 什么情况下会多个?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A分支,同一个commit 向B,C 分支提交PR,创建的check run,就会是同一个, 这时候 这个checkrun 获取的到的pullrequests 就会是多个。 checkrun的创建需要一个必填参数head-sha :the SHA of the commit, 这两次的创建的check run head-sha 会是相同的
https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那应该是能精确判断,本次重试是哪个PR吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果是关联多个PR的话 是没法确定重试的是那个PR, 多个PR下的checkrun其实就是同一个。
08e565c
to
0c83184
Compare