feat: copy linter binary to container #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reviewbot-x canceled.
|
wwcchh0123
force-pushed
the
feat/copylinter
branch
4 times, most recently
from
4cb2f5d
to
06ceb89
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 37.24% 37.20% -0.04%
==========================================
Files 27 27
Lines 1995 2013 +18
==========================================
+ Hits 743 749 +6
- Misses 1157 1165 +8
- Partials 95 99 +4 ☔ View full report in Codecov by Sentry. |
CarlJi
reviewed
Sep 6, 2024
config/config.go
Outdated
| @@ -38,13 +38,23 @@ type GlobalConfig struct { | |||
| JavaStyleCheckRuleConfig string `json:"javastylecheckruleConfig,omitempty"` | |||
| } | |||
|
|
|||
| type LogStorageConfig struct { | |||
CarlJi
reviewed
Sep 6, 2024
config/config.go
Outdated
| CustomRemoteConfigs map[string]any `json:"customRemoteConfigs"` | ||
| } | ||
|
|
||
| type GithubConfig struct{} |
CarlJi
reviewed
Sep 6, 2024
config/config.go
Outdated
| type GithubConfig struct{} | ||
|
|
||
| type DockerAsRunner struct { | ||
| Image string `json:"image,omitempty"` |
There was a problem hiding this comment.
DockerAsRunner 配置若存在，Image这里是不是应该必须要有？
CarlJi
reviewed
Sep 6, 2024
internal/runner/docker.go
Outdated
| log.Infof("container created: %v", resp.ID) | ||
|
|
||
| if cfg.DockerAsRunner.CopyLinterFromOrigin { | ||
| cmd := exec.Command("which", lintername) |
There was a problem hiding this comment.
CarlJi
reviewed
Sep 6, 2024
internal/runner/docker.go
Outdated
| linterOrignPath = string(cmdOutput[:len(cmdOutput)-1]) | ||
| } | ||
| if err != nil { | ||
| log.Errorf("failed to find %s :%v", lintername, err) |
CarlJi
reviewed
Sep 6, 2024
internal/runner/runner.go
Outdated
| @@ -46,7 +46,7 @@ func (l *LocalRunner) Prepare(ctx context.Context, cfg *config.Linter) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (l *LocalRunner) Run(ctx context.Context, cfg *config.Linter) (io.ReadCloser, error) { | |||
| func (l *LocalRunner) Run(ctx context.Context, cfg *config.Linter, lintername string) (io.ReadCloser, error) { | |||
There was a problem hiding this comment.
config.Linter 还是增加个属性Name，来做这个事情
Agent.LinterName 可以相应的删掉
wwcchh0123
force-pushed
the
feat/copylinter
branch
7 times, most recently
from
334a819
to
47997eb
Compare
wwcchh0123
force-pushed
the
feat/copylinter
branch
from
47997eb
to
e960ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.