Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gh-pages from docs Makefile #79

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

ElePT
Copy link
Collaborator

@ElePT ElePT commented Sep 27, 2023

Summary

Despite the docs content and makefile having migrated from the gh-pages branch to the docs directory in main a while ago, the github pages workflow was still set up to pull the documentation from gh-pages. For this reason, the docs updates were failing to show up in the page.

After changing the settings to pull the content from main, the https://qiskit-community.github.io/qiskit-cold-atom/ link broke down, and I believe it could be because of a couple of lines in the makefile that still refer to the gh-pages branch. This PR is an attempt to fix the workflow and restore the documentation link.

Details and comments

Copy link
Collaborator

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT merged commit 606e434 into qiskit-community:main Sep 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants