Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx-panels is unmaintained #1014

Closed
wshanks opened this issue Jan 17, 2023 · 3 comments · Fixed by #983
Closed

sphinx-panels is unmaintained #1014

wshanks opened this issue Jan 17, 2023 · 3 comments · Fixed by #983
Assignees
Labels
bug Something isn't working

Comments

@wshanks
Copy link
Collaborator

wshanks commented Jan 17, 2023

What is the current behavior?

sphinx-panels is listed in requirements-dev.txt but it is no longer maintained (see warning here. Besides it not being good to use software that is not maintained, an issue with sphinx-panels is that it sets a maximum version for sphinx which is getting out of date. New versions of other sphinx extensions like sphinx-autodoc-typehints set a higher minimum sphinx version than the maximum version of sphinx-panels.

Suggested solutions

sphinx-panels lists sphinx-design as the continuation of sphinx-panels. The only usage of sphinx-panels that I see searching the codebase is for the dropdown directive. sphinx-design has a dropdown directive and does not mention dropdown in the migration guide for sphinx-panels, so maybe it will work as a drop in replacement?

@wshanks wshanks added the bug Something isn't working label Jan 17, 2023
@wshanks
Copy link
Collaborator Author

wshanks commented Jan 17, 2023

@nkanazawa1989 I assigned to you because I think you added the usage of the dropdown directive?

@mtreinish
Copy link
Contributor

Fwiw, sphinx-design also sets a cap on the sphinx version iirc. I've been planning to stop using drop down directive in other places because of this (I started this for terra in Qiskit/qiskit#9087)

@wshanks
Copy link
Collaborator Author

wshanks commented Jan 17, 2023

Fwiw, sphinx-design also sets a cap on the sphinx version iirc

I hadn't looked into it further than seeing the warning on sphinx-panels about it not being maintained. The current version of sphinx-design limits sphinx to <6 and sphinx 6.1.3 is the latest version. However, sphinx 6.0 was only released 3 weeks ago and it looks like the hold up for sphinx-design is that their test dependencies have not all added support for sphinx 6 so they are waiting until their tests run against sphinx 6 according to executablebooks/sphinx-design#106 (comment).

For reference, I noticed this because I was trying to use pip-compile from pip-tools to trace the version of another dependency that was flagged by a security scanner and ended up getting this output:

There are incompatible versions in the resolved dependencies:                                                                                                                                
  Sphinx>=1.8.3 (from -r requirements-dev.txt (line 6))                                                                                                                                      
  sphinx (from qiskit-sphinx-theme==1.10.1->-r requirements-dev.txt (line 7))                                                                                                                
  sphinx>=1.8 (from nbsphinx==0.8.11->-r requirements-dev.txt (line 12))                                                                                                                     
  sphinx>=5.3 (from sphinx-autodoc-typehints==1.21.2->-r requirements-dev.txt (line 8))                                                                                                      
  sphinx<5,>=2 (from sphinx-panels==0.6.0->-r requirements-dev.txt (line 11)) 

coruscating added a commit that referenced this issue Mar 14, 2023
Refactoring existing docs into four new areas: tutorials, how-tos,
experiment guides, and the API reference. With contributions from
@chriseclectic, @wshanks, @jaleipekoglu, and @spencerking.

Main changes:
- Added introduction tutorials
- Added how-tos (this has a lot of room for future expansion)
- Added cards linking to each documentation area on the index page
- Organized experiment guides by type and with representative thumbnails
- Moved detailed API docs such as Curve Analysis to tutorials
- Consolidated previous calibrations guides into the new calibrations
tutorial
- Changed the `See Also` section in docstrings to render the rst
directly instead of parsing modules
- Closes #1014 by replacing `sphinx-panels` with `sphinx-design`
- Upgraded `qiskit-sphinx-theme` to >=1.10
- Removed usage of `qiskit-ibmq-provider` in docs and linked to
migration guide
- Parallelized sphinx build run (CI docs build went from 13 minutes to
10:20)
- Various fixes to remove all Sphinx build warnings and forces CI to
fail if there's a warning (warnings might still exist on mac)
- Cleaned up and removed unnecessary style and template files
- Added commands `tox -edocs-parallel` for a parallel build and renamed
no jupyter-execute command to `tox -edocs-minimal`

---------

Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Co-authored-by: Will Shanks <wshaos@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants