Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HamiltonianGate path and add tolerance to PulseBackend #1280

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

coruscating
Copy link
Collaborator

@coruscating coruscating commented Oct 1, 2023

Summary

After qiskit.extensions was deprecated in Qiskit/qiskit#10725, this PR updates the path of HamiltonianGate so tests against Qiskit main pass again. This also adds atol and rtol tolerance parameters to PulseBackend for speeding up slow tests.

@@ -37,7 +37,6 @@
MockIQParallelBackend
T2HahnBackend
NoisyDelayAerBackend
SingleTransmonTestBackend
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate entry.

@coruscating coruscating changed the title Update HamiltonianGate path Update HamiltonianGate path and add tolerance to PulseBackend Oct 16, 2023
Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I also ran into the hamiltonian_gate issue in #1285.

A few weeks ago I was looking at trying to get the SingleTransmonTestBackend faster by using jax, but I had to switch to other things before I could get somewhere. I think we need to look more at these tests at some point.

@wshanks wshanks added this pull request to the merge queue Oct 16, 2023
@wshanks
Copy link
Collaborator

wshanks commented Oct 16, 2023

A few weeks ago I was looking at trying to get the SingleTransmonTestBackend faster by using jax, but I had to switch to other things before I could get somewhere. I think we need to look more at these tests at some point.

Partly why I saw this is that while I was looking at them I noticed that the data in some of them was getting pretty sketchy looking from previous test speed up efforts -- meaning the rounds/tolerance were producing data that was fitting to reasonable numbers but looked pretty noisy.

Merged via the queue into qiskit-community:main with commit 73d0a03 Oct 16, 2023
10 checks passed
nkanazawa1989 pushed a commit to nkanazawa1989/qiskit-experiments that referenced this pull request Jan 10, 2024
…skit-community#1280)

### Summary

After `qiskit.extensions` was deprecated in
Qiskit/qiskit#10725, this PR updates the path of
`HamiltonianGate` so tests against Qiskit main pass again. This also
adds `atol` and `rtol` tolerance parameters to `PulseBackend` for
speeding up slow tests.
@coruscating coruscating added the backport stable potential The issue or PR might be minimal and/or import enough to backport to stable label Jan 23, 2024
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
)

### Summary

After `qiskit.extensions` was deprecated in
Qiskit/qiskit#10725, this PR updates the path of
`HamiltonianGate` so tests against Qiskit main pass again. This also
adds `atol` and `rtol` tolerance parameters to `PulseBackend` for
speeding up slow tests.

(cherry picked from commit 73d0a03)

# Conflicts:
#	qiskit_experiments/test/__init__.py
#	test/library/calibration/test_half_angle.py
#	test/library/calibration/test_rough_amplitude.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants