-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HamiltonianGate
path and add tolerance to PulseBackend
#1280
Update HamiltonianGate
path and add tolerance to PulseBackend
#1280
Conversation
@@ -37,7 +37,6 @@ | |||
MockIQParallelBackend | |||
T2HahnBackend | |||
NoisyDelayAerBackend | |||
SingleTransmonTestBackend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a duplicate entry.
HamiltonianGate
pathHamiltonianGate
path and add tolerance to PulseBackend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I also ran into the hamiltonian_gate issue in #1285.
A few weeks ago I was looking at trying to get the SingleTransmonTestBackend
faster by using jax, but I had to switch to other things before I could get somewhere. I think we need to look more at these tests at some point.
Partly why I saw this is that while I was looking at them I noticed that the data in some of them was getting pretty sketchy looking from previous test speed up efforts -- meaning the rounds/tolerance were producing data that was fitting to reasonable numbers but looked pretty noisy. |
…skit-community#1280) ### Summary After `qiskit.extensions` was deprecated in Qiskit/qiskit#10725, this PR updates the path of `HamiltonianGate` so tests against Qiskit main pass again. This also adds `atol` and `rtol` tolerance parameters to `PulseBackend` for speeding up slow tests.
) ### Summary After `qiskit.extensions` was deprecated in Qiskit/qiskit#10725, this PR updates the path of `HamiltonianGate` so tests against Qiskit main pass again. This also adds `atol` and `rtol` tolerance parameters to `PulseBackend` for speeding up slow tests. (cherry picked from commit 73d0a03) # Conflicts: # qiskit_experiments/test/__init__.py # test/library/calibration/test_half_angle.py # test/library/calibration/test_rough_amplitude.py
Summary
After
qiskit.extensions
was deprecated in Qiskit/qiskit#10725, this PR updates the path ofHamiltonianGate
so tests against Qiskit main pass again. This also addsatol
andrtol
tolerance parameters toPulseBackend
for speeding up slow tests.