Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set noise model basis gates for tomography tests #1294

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Oct 27, 2023

This sets the basis gates explicitly on the NoiseModel used for some tomography tests. Without this, some of the test circuits fail to transpile because reset is not in the equivalence library when using qiskit-aer 0.13.0 (see Qiskit/qiskit-aer#1975).

@wshanks wshanks added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: None Do not include in changelog labels Oct 27, 2023
Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though I wonder if we should remove it once the Aer fix is released.

@wshanks wshanks added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2023
@wshanks wshanks added this pull request to the merge queue Oct 31, 2023
@wshanks
Copy link
Collaborator Author

wshanks commented Oct 31, 2023

Yes, I agree. It looks like we can do that in Aer 0.13.1: Qiskit/qiskit-aer#1976.

Merged via the queue into qiskit-community:main with commit c2c6097 Oct 31, 2023
10 checks passed
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
This sets the basis gates explicitly on the `NoiseModel` used for some
tomography tests. Without this, some of the test circuits fail to
transpile because `reset` is not in the equivalence library when using
qiskit-aer 0.13.0 (see
Qiskit/qiskit-aer#1975).

(cherry picked from commit c2c6097)
@wshanks wshanks deleted the noise-model-reset branch October 31, 2023 16:13
wshanks added a commit that referenced this pull request Oct 31, 2023
)

This is an automatic backport of pull request #1294 done by
[Mergify](https://mergify.com).

---

Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
nkanazawa1989 pushed a commit to nkanazawa1989/qiskit-experiments that referenced this pull request Jan 17, 2024
This sets the basis gates explicitly on the `NoiseModel` used for some
tomography tests. Without this, some of the test circuits fail to
transpile because `reset` is not in the equivalence library when using
qiskit-aer 0.13.0 (see
Qiskit/qiskit-aer#1975).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants