-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set noise model basis gates for tomography tests #1294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshanks
added
backport stable potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: None
Do not include in changelog
labels
Oct 27, 2023
This was referenced Oct 27, 2023
coruscating
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, though I wonder if we should remove it once the Aer fix is released.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2023
Yes, I agree. It looks like we can do that in Aer 0.13.1: Qiskit/qiskit-aer#1976. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
This sets the basis gates explicitly on the `NoiseModel` used for some tomography tests. Without this, some of the test circuits fail to transpile because `reset` is not in the equivalence library when using qiskit-aer 0.13.0 (see Qiskit/qiskit-aer#1975). (cherry picked from commit c2c6097)
wshanks
added a commit
that referenced
this pull request
Oct 31, 2023
) This is an automatic backport of pull request #1294 done by [Mergify](https://mergify.com). --- Co-authored-by: Will Shanks <willshanks@us.ibm.com> Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 17, 2024
This sets the basis gates explicitly on the `NoiseModel` used for some tomography tests. Without this, some of the test circuits fail to transpile because `reset` is not in the equivalence library when using qiskit-aer 0.13.0 (see Qiskit/qiskit-aer#1975).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport stable potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: None
Do not include in changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the basis gates explicitly on the
NoiseModel
used for some tomography tests. Without this, some of the test circuits fail to transpile becausereset
is not in the equivalence library when using qiskit-aer 0.13.0 (see Qiskit/qiskit-aer#1975).